fix(native-filters): Add empty text node before OutPortal #22289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Horizontal filter bar resizing appears to be affected by this issue related to reverse portals: when an
<OutPortal />
is preceded by an element that is conditionally present or otherwise dynamic, React can crash. In this situation, opening the dropdown then attempting to resize down causes this crash. This PR follows the advice here and adds an empty text node before each<OutPortal />
and wraps the two elements in a fragment.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Untitled.2.mov
After:
Untitled.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
HORIZONTAL_FILTER_BAR