Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): Update owners of dashboard list after editing #22383

Merged
merged 1 commit into from
Dec 15, 2022
Merged

fix(dashboard): Update owners of dashboard list after editing #22383

merged 1 commit into from
Dec 15, 2022
+2 −0

Conversation

savvan0h
Copy link
Contributor

SUMMARY

Close #14001

#14001 also mentions title , but it's already fixed in #15186 .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

before

After

after

TESTING INSTRUCTIONS

  1. Go to Dashboards page
  2. Edit dashboard's owners
  3. See owners of dashboard list

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Dec 10, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

rusackas
rusackas approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Approving the CI run, and approving the code change, which LGTM.

CC @codyml since you've seen some risks in the arena of dashboard ownership before :)

villebro
villebro approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this valuable fix!

@villebro villebro merged commit 9f3c43f into apache:master Dec 15, 2022
This was referenced Jan 3, 2023
Merged
Merged
lilykuang pushed a commit that referenced this pull request Feb 25, 2023
@savvan0h
fix(dashboard): Update owners of dashboard list after editing (#22383)
e1cafa0 
(cherry picked from commit 9f3c43f)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@villebro villebro villebro approved these changes

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard properties do not update in dashboard list UI
5 participants
@savvan0h @rusackas @villebro @mistercrunch @eschutho