-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(celery) & docs(celery): update celery config variables names #22499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22499 +/- ##
==========================================
+ Coverage 66.90% 67.10% +0.20%
==========================================
Files 1851 1866 +15
Lines 70697 71337 +640
Branches 7764 7764
==========================================
+ Hits 47300 47873 +573
- Misses 21375 21442 +67
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with these changes, thanks for the cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
SUMMARY
CeleryConfig
indocker/pythonpath_dev/superset_config.py
are updated due to the lowercase settings introduced in version 4.0.worker_log_level
contained inconfig.py
is not mentioned anywhere in the celery documentation, therefore should be removed. It can be replaced withCELERYD_LOG_LEVEL
or could be removed. To configure logging level option-l
is used as mentioned here. This option is already used indocker-bootstrap.sh
:superset/docker/docker-bootstrap.sh
Line 40 in b954f8f
config.py
andsuperset_config.py
and could be removed.-O
was glued to its valuefair
like this:-Ofair
. Suggested change unglues them indocker-bootstrap.sh
andCONTRIBUTING.md
.ADDITIONAL INFORMATION