-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename filter_rel_fields to base_related_field_filters #22508
refactor: rename filter_rel_fields to base_related_field_filters #22508
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22508 +/- ##
===========================================
- Coverage 66.90% 55.79% -11.11%
===========================================
Files 1851 1851
Lines 70696 70696
Branches 7764 7764
===========================================
- Hits 47299 39447 -7852
- Misses 21375 29227 +7852
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with an optional comment on moving part of the docstring.
When combined with the `related_field_filters` attribute, | ||
this filter will be applied in addition to the latest:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this comment to related_field_filters
and say there that the filter is applied in addition (or on top, whichever sounds better) to base_related_field_filters
?
SUMMARY
Small refactor to improve the current confusing names for declaring related filters on
ModelRestApi
Renames:
filter_rel_fields
tobase_related_field_filters
currently we have:
filter_rel_fields
: That declared a base filter that is always applied on the declared related fieldsrelated_field_filters
: That applies a filter on related fieldsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION