Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: using bitly to manage expiring Slack invitation links #22631

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Jan 6, 2023

SUMMARY

The Slack invitation links posted all over the codebase, issues/PRs, and throughout the known universe, are always expiring. They either expire due to TTL, or as soon as 400 people join.

This PR replaces the links in the codebase with a bitly link.

That bitly link can be updated through a bitly account, which the PMC (and committers?) should have access to. This will be added to the new 1Password account - any PMC members who need access to this, please reach out.

When (not if) the link expires, please update the bitly link accordingly, and all the aliases floating around out there should remain functional. This will be a lot less disruptive and hopefully lead to more people joining!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Try this! bit.ly/join-superset-slack

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Links to slack are dead #22672
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #22631 (6aff4b0) into master (804e89d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22631   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files        1859     1859           
  Lines       71043    71043           
  Branches     7776     7776           
=======================================
  Hits        47622    47622           
  Misses      21397    21397           
  Partials     2024     2024           
Flag Coverage Δ
hive 52.48% <ø> (ø)
javascript 53.85% <ø> (ø)
mysql 78.04% <ø> (ø)
postgres 78.11% <ø> (ø)
presto 52.37% <ø> (ø)
python 81.37% <ø> (ø)
sqlite 76.49% <ø> (ø)
unit 51.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas requested a review from eschutho January 6, 2023 23:38
@rusackas rusackas requested review from a team and geido January 12, 2023 05:47
@rusackas rusackas merged commit a1f1e4f into master Jan 12, 2023
@rusackas rusackas deleted the replacing-Slack-invite-link-with-bitly-link branch January 12, 2023 21:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants