fix: alert modal bug fix

[AAfghahi]

SUMMARY

Due to some refactoring, we were no longer updating the dropdown in the alert/report modal when a user switched from one alert option to another.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #22688 (1024cd6) into master (0b22287) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22688      +/-   ##
==========================================
- Coverage   67.07%   66.92%   -0.16%     
==========================================
  Files        1869     1870       +1     
  Lines       71579    72501     +922     
  Branches     7806     8162     +356     
==========================================
+ Hits        48015    48519     +504     
- Misses      21536    21910     +374     
- Partials     2028     2072      +44     

Flag	Coverage Δ
hive	52.60% <ø> (ø)
javascript	53.89% <100.00%> (-0.07%)	⬇️
mysql	78.01% <ø> (?)
postgres	78.08% <ø> (+0.01%)	⬆️
presto	52.49% <ø> (ø)
python	81.31% <ø> (+0.04%)	⬆️
sqlite	76.48% <ø> (ø)
unit	51.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set-frontend/src/components/Select/AsyncSelect.tsx	88.52% <100.00%> (+0.28%)	⬆️
...ns/legacy-plugin-chart-map-box/src/controlPanel.ts	23.07% <0.00%> (-6.93%)	⬇️
...perset-frontend/src/views/components/RightMenu.tsx	77.43% <0.00%> (-0.80%)	⬇️
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx	90.47% <0.00%> (-0.44%)	⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx	80.57% <0.00%> (-0.24%)	⬇️
superset-frontend/src/types/bootstrapTypes.ts	100.00% <0.00%> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx	100.00% <0.00%> (ø)
...rontend/src/filters/components/Range/buildQuery.ts	0.00% <0.00%> (ø)
...d/src/SqlLab/components/QueryLimitSelect/index.tsx	100.00% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <0.00%> (ø)
... and 40 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

@AAfghahi can you add more context to the PR description? I'm trying to understand the problem because initialOptions is calculated from options:

const initialOptions = useMemo(
  () => options && Array.isArray(options) ? options.slice() : EMPTY_OPTIONS,
  [options],
);

[AAfghahi]

Yeah! So, in AlertReportModal, what we are sending over to options is not an array, it returns this:
https://github.com/apache/superset/blob/master/superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx#L811

so this fails the Array.isArray(options) and does not update initialOptions, and leaves initialOptions as EMPTY_OPTIONS. This is what was causing the behavior from before.

[michael-s-molina]

I understood. I think we had a problem during the refactoring. For the async Select, we don't have initial options so we can remove the references to it. I'm sending you a patch with the changes. Let me know if AlertReportModal works after applying it with git apply patch.txt

patch.txt

[AAfghahi]

/testenv up

[github-actions]

@AAfghahi Ephemeral environment spinning up at http://54.184.216.139:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

LGTM

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.