feat(ssh_tunnel): Rename allow_ssh_tunneling and change the default value to False #22723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonio-RiveroMartnez
changed the title
Codecov Report
@@ Coverage Diff @@
## master #22723 +/- ##
==========================================
- Coverage 67.13% 65.59% -1.54%
==========================================
Files 1869 1869
Lines 71656 71658 +2
Branches 7822 7822
==========================================
- Hits 48103 47006 -1097
- Misses 21526 22625 +1099
Partials 2027 2027
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eschutho
reviewed
Jan 13, 2023
superset/db_engine_specs/base.py
Outdated
| @@ -193,7 +193,7 @@ class BaseEngineSpec: # pylint: disable=too-many-public-methods | |||
| engine_aliases: Set[str] = set() | |||
| drivers: Dict[str, str] = {} | |||
| default_driver: Optional[str] = None | |||
| allow_ssh_tunneling = False | |||
| allow_ssh_tunneling = True | |||
There was a problem hiding this comment.
This is kind of a nit, but I think your first inclination to make the default value False was a good one and follows convention. Can we instead flip the behavior, so something like disable_ssh_tunneling = False
There was a problem hiding this comment.
Oh! Ok, yeah, makes sense, let me change it
- Change the default value of allow_ssh_tunneling flag so it's always true except for those DB engines we know it's not supported
- Change the allow_ssh_tunneling for disable_ssh_tunneling to follow convention as before when the flag was set by default to false
Antonio-RiveroMartnez
force-pushed
the
ssh_tunnel_flag
branch
from
472df8d to
044e51c
Compare
Antonio-RiveroMartnez
changed the title
eschutho
approved these changes
Jan 17, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
allow_ssh_tunnelingflag so it's nowdisable_ssh_tunneling, always false except for those DB engines we know it's not supported (Amazon Athena, GSheets and BigQuery so far)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION