Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds a separator to Select All option #22776

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

  • Adds a separator to Select All option
  • Sorts the controls alphabetically

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-01-18 at 9 12 52 AM

Screenshot 2023-01-18 at 9 08 01 AM

TESTING INSTRUCTIONS

Check that there's a separator between Select All and the other options

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #22776 (5012b5e) into master (577ac81) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22776   +/-   ##
=======================================
  Coverage   67.29%   67.29%           
=======================================
  Files        1877     1877           
  Lines       71939    71939           
  Branches     7877     7877           
=======================================
  Hits        48412    48412           
  Misses      21499    21499           
  Partials     2028     2028           
Flag Coverage Δ
javascript 53.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 91.61% <ø> (ø)
superset-frontend/src/components/Select/styles.tsx 80.76% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 1fe4a71 into apache:master Jan 19, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants