Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Bard): re-enabling and de-flaking a Cypress test (in theory) #24101

Closed
wants to merge 3 commits into from

Conversation

rusackas
Copy link
Member

SUMMARY

This test was previously xit-ed in another PR because it was the flakiest of all tests. Let's see if Bard can fix that!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #24101 (3726c0d) into master (5192925) will increase coverage by 1.60%.
The diff coverage is n/a.

❗ Current head 3726c0d differs from pull request most recent head f776835. Consider uploading reports for the commit f776835 to get more accurate results

@@            Coverage Diff             @@
##           master   #24101      +/-   ##
==========================================
+ Coverage   66.70%   68.30%   +1.60%     
==========================================
  Files        1951     1951              
  Lines       75385    75382       -3     
  Branches     8185     8185              
==========================================
+ Hits        50283    51493    +1210     
+ Misses      22999    21786    -1213     
  Partials     2103     2103              
Flag Coverage Δ
javascript 54.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/hive.py 87.45% <ø> (+0.97%) ⬆️
superset/db_engine_specs/presto.py 87.78% <ø> (+1.20%) ⬆️
superset/db_engine_specs/trino.py 84.00% <ø> (+40.00%) ⬆️

... and 86 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas closed this May 17, 2023
@mistercrunch mistercrunch deleted the de-flaking-test-2 branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant