Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump prophet and holidays (predictive forecasting) #24426

Closed

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

This PR bumps optional dependency prophet for the predictive forecasting feature. Prophet made huge performance gains in the last releases https://github.com/facebook/prophet/releases and dropped some dependencies.

Sped up .predict() by up to 10x by removing intermediate DataFrame creations.

Also bumped holidays as needed for prophet. https://github.com/dr-prodigy/python-holidays/releases

Note: Although prophet worked before and after the bump, their related integration tests still fail #24406. So this PR may be blocked by this issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

  • pip install -e '.[prophet]'
  • Setup Line chart and enable predictive forecast

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #24426 (4e74339) into master (23bb1c4) will not change coverage.
The diff coverage is n/a.

❗ Current head 4e74339 differs from pull request most recent head a81892d. Consider uploading reports for the commit a81892d to get more accurate results

@@           Coverage Diff           @@
##           master   #24426   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files        1904     1904           
  Lines       73920    73920           
  Branches     8119     8119           
=======================================
  Hits        50944    50944           
  Misses      20865    20865           
  Partials     2111     2111           
Flag Coverage Δ
hive 53.92% <ø> (ø)
mysql 79.20% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 53.85% <ø> (ø)
python 83.28% <ø> (ø)
sqlite 77.79% <ø> (ø)
unit 54.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro
Copy link
Member

Nice one @sebastianliebscher ! ❤️ FYI, @john-bodley has a related PR in the works, but maybe we can get this merged first and then fast follow John's PR to get those tests etc cleaned up.

@sebastianliebscher
Copy link
Contributor Author

@villebro maybe you can also have a look at this discussion #24357

@john-bodley
Copy link
Member

@sebastianliebscher thanks for the PR. Personally I would prefer #24129 as it reenables the tests which highlighted a few issues with the way prophet was used/configured.

There's a CI issue I still need to look into, i.e., for some reason the test fails on MySQL but works for SQLite and Postgres.

@sebastianliebscher
Copy link
Contributor Author

sebastianliebscher commented Jun 16, 2023

Oh, didn't see your PR which will handle the bump + fixing the tests.

Closed in favor of #24129

@sebastianliebscher sebastianliebscher deleted the bump_prophet branch June 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants