Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker (build) without DOCKER_BUILDKIT #24507

Closed
wants to merge 1 commit into from
Closed

docker (build) without DOCKER_BUILDKIT #24507

wants to merge 1 commit into from

Conversation

alekseyolg
Copy link
Contributor

According to #24504 if you remove DOCKER_BUILDKIT=1 then this should not affect the build process

TESTING INSTRUCTIONS
Manually build from the Dockerfile,

docker build -t superset

And the build should finish without error.

Successfully tagged superset:latest

According to #24504 if you remove DOCKER_BUILDKIT=1 then this should not affect the build process
@sebastianliebscher
Copy link
Contributor

@alekseyolg
Copy link
Contributor Author

alekseyolg commented Jun 24, 2023

@sebastianliebscher I tried creating a test pull request with your suggestion, but it failed on build

https://github.com/apache/superset/actions/runs/5365790263/jobs/9734827799?pr=24507

Apparently, this option is still necessary for the build (but if you believe your links, everything should work successfully).

If you have no idea why this is happening, then I suggest closing this pull request.

@alekseyolg
Copy link
Contributor Author

Since this idea was not working - I close it.

@alekseyolg alekseyolg closed this Jun 26, 2023
@alekseyolg
Copy link
Contributor Author

Since this idea was not working - I close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants