Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(embedded sdk): Remove trailing slash from passed superset domain if there is one #25020

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(embedded sdk): Remove trailing slash from passed superset domain if there is one #25020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions superset-embedded-sdk/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion superset-embedded-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@superset-ui/embedded-sdk",
"version": "0.1.0-alpha.9",
"version": "0.1.0-alpha.10",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

side note, when do you think we should we consider this not an alpha feature and bump the sdk to a stable version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have a strong opinion on this, but maybe it makes sense to do soon simply due to it being released for over a year now with no major issues? cc @lilykuang who may have more context

"description": "SDK for embedding resources from Superset into your own application",
"access": "public",
"keywords": [
Expand Down
4 changes: 4 additions & 0 deletions superset-embedded-sdk/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ export async function embedDashboard({

log('embedding');

if (supersetDomain.endsWith("/")) {
supersetDomain = supersetDomain.slice(0, -1);
}

function calculateConfig() {
let configNumber = 0
if(dashboardUiConfig) {
Expand Down
Loading