fix(explore): cannot reorder dnd of Metrics #28269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusackas
approved these changes
Apr 29, 2024
|
@justinpark Can you link the original issues in a way that they will be automatically closed when the PR is merged? You can do this by using an isolated sentence in your PR description like "Fixes #28111" or linking the PR using the Development panel: The following sentence will NOT automatically close the issue:
I updated your PR description with: |
3 tasks
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
May 1, 2024
(cherry picked from commit 7c8423a)
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
mistercrunch
added
🍒 4.0.1
🍒 4.0.2
🏷️ bot
irublev
pushed a commit
to HighviewPower/superset
that referenced
this pull request
Oct 29, 2024
(cherry picked from commit 68674ad)
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes target branch of #28111 to master.
Due to the issue of the metric dnd item containing with an invalid property name for dragIndex, the highlight dropzone has been overlapping with the dragging item. As a result, the dnd of metrics cannot be reordered effectively.
Fixes #28013
Fixes #28273
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--dnd-metric-sortable.mov
After:
after--dnd-metric-sortable.mov
TESTING INSTRUCTIONS
Go to Charts
Get two metrics in the metrics pane for Table view
Try to reorder them.
ADDITIONAL INFORMATION