Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): uplift webpack-related packages to v5 #28342

Merged
merged 2 commits into from
May 8, 2024
Merged

chore(build): uplift webpack-related packages to v5 #28342

merged 2 commits into from
May 8, 2024
+1,583 −473

Conversation

hainenber
Copy link
Contributor

chore(build): uplift webpack-related packages to webpack5-supported version

SUMMARY

Uplift the webpack-related packages to webpack5-supported version for currency and fix any associated vulnerabilities.
There's a small config refactor in superset-frontend's webpack.config.js made by following webpack-dev-server's migration guide

I run npm run dev, npm run build and npm run dev-server and all things look good.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run npm run dev, npm run build-dev and npm run dev-server

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hainenber
chore(build): uplift webpack-related packages to v5
dbba81e 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber changed the title chore(build): uplift webpack-related packages to v5 chore(build): uplift webpack-related packages to v5 May 4, 2024
@hainenber
fix(build): update lockfile for webpack-manifest-plugin
a22b794 
Signed-off-by: hainenber <dotronghai96@gmail.com>
@rusackas rusackas requested a review from kgabryje May 6, 2024 22:25
kgabryje
kgabryje approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2024
@kgabryje kgabryje merged commit 8c27d4d into apache:master May 8, 2024
28 checks passed
kgabryje added a commit to kgabryje/incubator-superset that referenced this pull request May 8, 2024
@kgabryje
Revert "chore(build): uplift webpack-related packages to v5 (apache…
4d00992 
…#28342)"

This reverts commit 8c27d4d.
@kgabryje kgabryje mentioned this pull request May 8, 2024
Merged
9 tasks
@michael-s-molina
Copy link
Member

@hainenber @kgabryje It looks like the correct way of implementing the desired behavior is to use the afterEmit compiler hook instead of a middleware.

kgabryje added a commit that referenced this pull request May 8, 2024
@kgabryje
fix: Revert "chore(build): uplift webpack-related packages to v5 (#…
5a13e64 
…28342)" (#28384)
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@hainenber
chore(build): uplift webpack-related packages to v5 (apache#28342)
c217b2c 
Signed-off-by: hainenber <dotronghai96@gmail.com>
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
@kgabryje
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
b6ca40a 
…pache#28342)" (apache#28384)
@hainenber hainenber deleted the uplift-webpack-related-packages-to-v5 branch May 12, 2024 06:05
@hainenber hainenber mentioned this pull request May 12, 2024
Closed
9 tasks
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@hainenber @jzhao62
chore(build): uplift webpack-related packages to v5 (apache#28342)
7b12cbf 
Signed-off-by: hainenber <dotronghai96@gmail.com>
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
@kgabryje @jzhao62
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
f94ff27 
…pache#28342)" (apache#28384)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@hainenber @EnxDev
chore(build): uplift webpack-related packages to v5 (apache#28342)
95107f6 
Signed-off-by: hainenber <dotronghai96@gmail.com>
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@kgabryje @EnxDev
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
f47ed84 
…pache#28342)" (apache#28384)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@hainenber
chore(build): uplift webpack-related packages to v5 (apache#28342)
6984fab 
Signed-off-by: hainenber <dotronghai96@gmail.com>
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@kgabryje
fix: Revert "chore(build): uplift webpack-related packages to v5 (a…
c7348e2 
…pache#28342)" (apache#28384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@justinpark justinpark Awaiting requested review from justinpark

Assignees
No one assigned
Labels
dependencies:npm embedded lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hainenber @michael-s-molina @kgabryje