Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Ant Design 5 Theme #29328

Merged
merged 3 commits into from
Jun 28, 2024
Merged

feat: Add Ant Design 5 Theme #29328

merged 3 commits into from
Jun 28, 2024

Conversation

geido
Copy link
Member

@geido geido commented Jun 21, 2024

SUMMARY

This work is part of SIP 139 #29268.
This PR introduces Ant Design 5 in the repo and adds the initial Ant Design mapping with the original Superset theme to allow overrides through preamble. This should serve as the base for the Ant Design upgrade. As new components are upgraded, this initial mapping will be adjusted accordingly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N.A.

TESTING INSTRUCTIONS

All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend global:theming Related to theming Superset labels Jun 21, 2024
@michael-s-molina
Copy link
Member

Can you convert this to a draft given that the SIP was not approved yet?

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Jun 21, 2024
@geido geido marked this pull request as draft June 21, 2024 17:38
@geido geido force-pushed the geido/feat/ant-design-5-theme branch from 46348ec to 219f856 Compare June 21, 2024 22:31
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 24, 2024
@geido geido marked this pull request as ready for review June 26, 2024 08:52
@geido
Copy link
Member Author

geido commented Jun 26, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://52.35.19.68:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

This was referenced Jun 27, 2024
Merged
Merged
kgabryje
kgabryje reviewed Jun 27, 2024
View reviewed changes
superset-frontend/src/theme/light.ts
fontSizeSM: supersetTheme.typography.sizes.s,
fontSizeXL: supersetTheme.typography.sizes.xl,

lineWidthBold: supersetTheme.gridUnit / 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: do we want to tie this to the grid unit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revisit this as we continue the upgrade. The general theme is the result of the usage of the individual components, so this needs to be thought of as a draft for now.

kgabryje
kgabryje approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Suggestion for future iterations - since antd5's theming is a new concept in Superset, could we have some descriptive comments or references to docs where they're relevant (such as what is a theme algorithm, what tokens are available etc)? I think it will make the transition easier for us

@geido geido merged commit 2a587a7 into master Jun 28, 2024
59 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the geido/feat/ant-design-5-theme branch June 28, 2024 15:43
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@geido @eschutho
feat: Add Ant Design 5 Theme (#29328)
8496271
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

@rusackas rusackas Awaiting requested review from rusackas

@justinpark justinpark Awaiting requested review from justinpark

@eschutho eschutho Awaiting requested review from eschutho

@Antonio-RiveroMartnez Antonio-RiveroMartnez Awaiting requested review from Antonio-RiveroMartnez

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend dependencies:npm global:theming Related to theming Superset size/L 🚢 4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geido @michael-s-molina @kgabryje @mistercrunch @john-bodley