From d11fe2640fe37a355773f2476b8f363a3ea70ad9 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Tue, 11 Sep 2018 23:04:47 -0700 Subject: [PATCH 1/2] remove unused functions and jquery dependency --- superset/assets/src/chart/ChartBody.jsx | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/superset/assets/src/chart/ChartBody.jsx b/superset/assets/src/chart/ChartBody.jsx index b459f4418207d..c2595e22bb730 100644 --- a/superset/assets/src/chart/ChartBody.jsx +++ b/superset/assets/src/chart/ChartBody.jsx @@ -1,6 +1,5 @@ import React from 'react'; import PropTypes from 'prop-types'; -import $ from 'jquery'; const propTypes = { containerId: PropTypes.string.isRequired, @@ -19,18 +18,6 @@ class ChartBody extends React.PureComponent { this.el.style[property] = value; } - get(n) { - return $(this.el).get(n); - } - - find(classname) { - return $(this.el).find(classname); - } - - show() { - return $(this.el).show(); - } - height() { return this.props.height(); } From 13e73cc153f02d195faf80d5fef363c7251b013b Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Mon, 17 Sep 2018 11:55:20 -0700 Subject: [PATCH 2/2] rebase and remove more obsolete functions --- superset/assets/src/chart/ChartBody.jsx | 8 -------- 1 file changed, 8 deletions(-) diff --git a/superset/assets/src/chart/ChartBody.jsx b/superset/assets/src/chart/ChartBody.jsx index c2595e22bb730..4ab7364ea8cf4 100644 --- a/superset/assets/src/chart/ChartBody.jsx +++ b/superset/assets/src/chart/ChartBody.jsx @@ -10,14 +10,6 @@ const propTypes = { }; class ChartBody extends React.PureComponent { - html(data) { - this.el.innerHTML = data; - } - - css(property, value) { - this.el.style[property] = value; - } - height() { return this.props.height(); }