Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMP] Audit mixed precision operation schedules for correctness #8340

Closed
8 tasks
AndrewZhaoLuo opened this issue Jun 25, 2021 · 2 comments
Closed
8 tasks

[AMP] Audit mixed precision operation schedules for correctness #8340

AndrewZhaoLuo opened this issue Jun 25, 2021 · 2 comments

Comments

@AndrewZhaoLuo
Copy link
Contributor

Some operations like conv2d and matmul support heterogenous output datatypes.

E.g. the operation could be done with float16 operands but accumulate the result in float32.

However, some schedules for these ops don't actually support mixed precision types. For example python/tvm/topi/cuda/conv2d_winograd.py has a type error if the output dtype is not the same as the input dtypes.

This issue is to audit operations which support output datatypes (e.g. have the out_dtype attribute) and make sure corresponding schedules support the feature. For every schedule this will involve adding a unittest.

List of ops to examine

  • "nn.conv1d",
  • "nn.conv2d",
  • "nn.conv3d",
  • "nn.conv1d_transpose",
  • "nn.conv2d_transpose",
  • "nn.conv3d_transpose",
  • "nn.dense",
  • "nn.batch_matmul"
@AndrewZhaoLuo AndrewZhaoLuo changed the title Audit mixed precision operation schedules for correctness [AMP] Audit mixed precision operation schedules for correctness Jun 25, 2021
@AndrewZhaoLuo
Copy link
Contributor Author

#8517 might fix this if it is not too controversial.

@AndrewZhaoLuo
Copy link
Contributor Author

Closing as #8517 should have fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant