Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hexagon] Codegen for 2d Load/Store #10586

Merged
merged 8 commits into from
Mar 15, 2022
Merged

[Hexagon] Codegen for 2d Load/Store #10586

merged 8 commits into from
Mar 15, 2022

Commits on Mar 11, 2022

  1. Added unit tests for codegen of 2d physical buffers in Hexagon.

    @Lunderberg
    Lunderberg committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    75eb0d1 View commit details
    Browse the repository at this point in the history

  2. Update IndexMap when buffers are updated.

    @Lunderberg
    Lunderberg committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    03e1f84 View commit details
    Browse the repository at this point in the history

  3. Extended CodeGenLLVM::BufferAccessHelper to support N-d 

    This way, a subclass can override GetBufferPtr, without needing to
reimplement all of the other indexing logic for
BufferLoad/BufferStore.
    @Lunderberg
    Lunderberg committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    ac797b3 View commit details
    Browse the repository at this point in the history

  4. Updated CodeGenHexagon to treat 2-d physical buffers as T**

    @Lunderberg
    Lunderberg committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    867c424 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Moved indices size check earlier. 

    Previous location in `CodeGenLLVM::BufferAccessHelper` occurred after
possible integer wrapping in `indices.size()-1` loop bounds.
    @Lunderberg
    Lunderberg committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    b4a3089 View commit details
    Browse the repository at this point in the history

  2. Updated to use llvm::ArrayRef instead of std::vector.

    @Lunderberg
    Lunderberg committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    aab3410 View commit details
    Browse the repository at this point in the history

  3. Resolve lint error.

    @Lunderberg
    Lunderberg committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    85b210b View commit details
    Browse the repository at this point in the history

  4. CI fix, contextlib.nullcontext not available on python3.6

    @Lunderberg
    Lunderberg committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    b3ae624 View commit details
    Browse the repository at this point in the history