-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[microNPU] Some housekeeping in the test_ethosu folder #10824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lhutton1 @manupa-arm @NicolaLancellotti an unglamorous refactor :) |
lhutton1
approved these changes
Mar 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @ekalda LGTM
* Move the utility functions from test_codegen.py into infra.py for wider accessibility * Remove some unused code * Make the conv2d codegen tests more general
ekalda
force-pushed
the
refactor-test-codegen
branch
from
March 30, 2022 16:23
5917e2f
to
88537c5
Compare
NicolaLancellotti
approved these changes
Mar 31, 2022
manupak
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @ekalda for the refactor |
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder * Move the utility functions from test_codegen.py into infra.py for wider accessibility * Remove some unused code * Make the conv2d codegen tests more general * Update test_identity_optimizer.py * Update test_lut_optimizer.py
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder * Move the utility functions from test_codegen.py into infra.py for wider accessibility * Remove some unused code * Make the conv2d codegen tests more general * Update test_identity_optimizer.py * Update test_lut_optimizer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wider accessibility