Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microNPU] Some housekeeping in the test_ethosu folder #10824

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

ekalda
Copy link
Contributor

@ekalda ekalda commented Mar 30, 2022

  • Move the utility functions from test_codegen.py into infra.py for
    wider accessibility
  • Remove some unused code
  • Make the conv2d codegen tests more general

@ekalda
Copy link
Contributor Author

ekalda commented Mar 30, 2022

@lhutton1 @manupa-arm @NicolaLancellotti an unglamorous refactor :)

Copy link
Contributor

@lhutton1 lhutton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @ekalda LGTM

* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general
Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manupak manupak merged commit 8226bd0 into apache:main Mar 31, 2022
@manupak
Copy link
Contributor

manupak commented Mar 31, 2022

Thanks @ekalda for the refactor

pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder

* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general

* Update test_identity_optimizer.py

* Update test_lut_optimizer.py
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Apr 11, 2022
* [microNPU] Some housekeeping in the test_ethosu folder

* Move the utility functions from test_codegen.py into infra.py for
  wider accessibility
* Remove some unused code
* Make the conv2d codegen tests more general

* Update test_identity_optimizer.py

* Update test_lut_optimizer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants