-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Add schedule primitive SetAxisSeparator #11225
Conversation
d4d31d5
to
e59b977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! I really like the ReplaceBufferMutator
utility, and look forward to using it elsewhere as well!
@Lunderberg @vinx13 This is great, thanks a lot, I would love to start using this. I do have a small doubt however. Is there a reason why we're introducing a new schedule primitive instead of allowing the user to pass something similar to The reason for this question is that the list to be passed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding axis separator support to TIR scheduling! I also really love ReplaceBufferMutator, not only very useful but edifying as a concise description of all the places buffer rewrites may need to occur. Just a few comments, only one really needs addressing.
@quic-sanirudh Thanks for the comments. The motivation to have a separate schedule primitive is to decouple the logical-physical mapping from generic layout transformation which doesn't have to deal with physical layout. @Lunderberg suggested that we can have a user convenience API backed by these two schedule primitives |
Ah okay, thanks for the reply @vinx13 |
Many thanks @vinx13 @quic-sanirudh @junrushao1994 @Lunderberg, this is merged! |
* [TIR] Add schedule primitive SetAxisSeparator * remove unused include * Move ReplaceBufferMutator impl to cc file
* [TIR] Add schedule primitive SetAxisSeparator * remove unused include * Move ReplaceBufferMutator impl to cc file
This PR added a schedule primitive
set_axis_separator
, it modifiesaxis_separators
attribute of the target buffer, which affects the physical dimension after flattening.cc @Lunderberg @csullivan @junrushao1994