[tir] remove unused member variable #11248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused member variable `tvm::tir::PackedCallLegalizer::tvm_value_index_`. This also fixes a GCC 7.5 compiler warning.
cconvey
commented
May 9, 2022
| @@ -111,8 +111,7 @@ class PackedCallLegalizer : public StmtExprMutator { | |||
|
|
|||
| private: | |||
| IRModule mod_; | |||
| InputMap inputs_; // Store the inputs to the primfunc that don't need to be packed. | |||
| int tvm_value_index_; // Index of the actual tvm_value variable | |||
| InputMap inputs_; // Store the inputs to the primfunc that don't need to be packed. | |||
There was a problem hiding this comment.
I think this line only changed because clang-format removed some white-space.
vinx13
approved these changes
May 9, 2022
|
@Hzfengsy @spectrometerHBH : Ready for commit. |
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 16, 2022
Remove unused member variable `tvm::tir::PackedCallLegalizer::tvm_value_index_`. This also fixes a GCC 7.5 compiler warning.
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
Remove unused member variable `tvm::tir::PackedCallLegalizer::tvm_value_index_`. This also fixes a GCC 7.5 compiler warning.
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
Remove unused member variable `tvm::tir::PackedCallLegalizer::tvm_value_index_`. This also fixes a GCC 7.5 compiler warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused member variable
tvm::tir::PackedCallLegalizer::tvm_value_index_.This also fixes a GCC 7.5 compiler warning.