[PROFILER] Add configuration information to profiler #11530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration is a place to store extra information related to the specific profiler run. Right now it is just the executor used and the number of threads. The roofline analysis also adds peak flops and peak bandwidth.
areusch
approved these changes
Jun 3, 2022
|
Will review today and hopefully merge |
| return s.str(); | ||
| } | ||
|
|
||
| std::string DeviceString(Device dev) { | ||
| return DeviceName(dev.device_type) + std::to_string(dev.device_id); | ||
| } | ||
|
|
||
| Report Profiler::Report(bool aggregate, bool sort) { | ||
| Report Profiler::Report() { |
There was a problem hiding this comment.
Interesting these variables were never used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration is a place to store extra information related to the specific profiler run. Right now it is just the executor used and the number of threads. The roofline analysis also adds peak flops and peak bandwidth.
In the future I'd like to add information about the target, but it would have to be piped through the compiled library.
@AndrewZhaoLuo @areusch