Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Arith][TIR] Check for constant offsets of known literal constraints #13023

Merged

Commits on Oct 28, 2022

  1. [Arith][TIR] Check for constant offsets of known literal constraints

    Previously, the checks for a literal constraint would find exact
    matches for an inequality, but any alterations to the conditional
    would break this exact matching.  This commit introduces checks for
    constant offsets relative to a known value.  These checks are not
    always expressible using the existing `ConstIntSetAnalyzer`, which
    represents allowed values using a single contiguous
    region.  (e.g. `i!=5` is not representable, because it requires a
    region for `i<5` and another for `i>5`.)
    
    This implementation reuses the internal representation for
    inequalities introduced in apache#12863,
    along with much of its implementation.  However, the indirect
    comparisons (e.g. using `a < b` and `b < c` to prove that `a < c`)
    introduced in that PR still require an explicit flag to be used.
    Lunderberg committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bb2f4ed View commit details
    Browse the repository at this point in the history