Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary VTCM workspace APIs #13681

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

janetsc
Copy link
Collaborator

@janetsc janetsc commented Jan 3, 2023

AllocVtcmWorkspace and FreeVtcmWorkspace were temporary APIs for allocating VTCM. Now that AllocDataSpace supports VTCM, these can be removed as they are just wrappers.

cc: @adstraw

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to auto-tag found, no teams are specified in PR title See #10317 for details

Generated by tvm-bot

@janetsc janetsc marked this pull request as ready for review January 3, 2023 15:54
@janetsc janetsc requested review from Lunderberg and csullivan and removed request for Lunderberg January 3, 2023 15:54
Copy link
Contributor

@Lunderberg Lunderberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, and thank you on the cleanup!

@Lunderberg Lunderberg merged commit 48ef3a2 into apache:main Jan 4, 2023
@adstraw
Copy link
Contributor

adstraw commented Jan 4, 2023

LGTM as well. Thanks @janetsc

@janetsc janetsc deleted the remove_vtcm_workspace_apis branch March 21, 2023 16:35
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants