Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVMScript] Robustify the Highlight Printer #13861

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

Hzfengsy
Copy link
Member

Current cprint allows PrimFunc and IRModule as input. However, after the fragment printing enabled by @junrushao, we can make it robust to support any Objects that have method script

cc @junrushao @cyx-6

Current `cprint` allows `PrimFunc` and `IRModule` as input. However,
after the fragment printing enabled by @junrushao, we can make it robust
to support any Objects that have method `script`
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 29, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@junrushao
Copy link
Member

Shall we fix the CI error and get it in?

@junrushao junrushao merged commit 4daf38f into apache:main Jan 31, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Current `cprint` allows `PrimFunc` and `IRModule` as input. However,
after the fragment printing enabled by @junrushao, we can make it robust
to support any Objects that have method `script`
@Hzfengsy Hzfengsy deleted the robustify_highlight_printer branch November 5, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants