Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Allow scalar tensors to have null shape during allocation #14376

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

janetsc
Copy link
Collaborator

@janetsc janetsc commented Mar 23, 2023

Update assert during buffer allocation. Zero dimensional tensors (scalars) can have a null shape.

cc: @csullivan, @farshidsp

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 23, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@janetsc janetsc requested a review from Lunderberg March 23, 2023 15:13
@janetsc
Copy link
Collaborator Author

janetsc commented Mar 23, 2023

@tvm-bot rerun

@janetsc janetsc changed the title [Hexagon] Allow scalar tensors to have null shape during allocation. [Hexagon] Allow scalar tensors to have null shape during allocation Mar 23, 2023
@janetsc
Copy link
Collaborator Author

janetsc commented Mar 23, 2023

@tvm-bot rerun

@janetsc janetsc marked this pull request as ready for review March 23, 2023 19:39
Copy link
Contributor

@csullivan csullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants