Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[relay][frontend][pytorch]Fix a bug in the _get_pytorch_value_type function #14421

Merged
merged 2 commits into from
Mar 30, 2023
Merged

[relay][frontend][pytorch]Fix a bug in the _get_pytorch_value_type function #14421

merged 2 commits into from
Mar 30, 2023

Conversation

liwangshengya
Copy link
Contributor

Fixed a bug in _get_pytorch_value_type(): kind should be used to determine if it is an OptionalType, instead of pt_dtype

@tvm-bot
Copy link
Collaborator

tvm-bot commented Mar 29, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@masahi
Copy link
Member

masahi commented Mar 29, 2023

Thanks, please fix lint.

@liwangshengya
Copy link
Contributor Author

@masahi I have have corrected the lint.

@masahi
Copy link
Member

masahi commented Mar 29, 2023

@tvm-bot rerun

@masahi masahi merged commit 9f6ce7c into apache:main Mar 30, 2023
@liwangshengya liwangshengya deleted the fix_relay_pytorch branch March 31, 2023 05:31
@ysh329 ysh329 mentioned this pull request Apr 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masahi masahi masahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liwangshengya @tvm-bot @masahi