Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIR] Update SplitHostDevice to post-process with ConvertSSA #14496

Merged
merged 2 commits into from
Apr 8, 2023
Merged

[TIR] Update SplitHostDevice to post-process with ConvertSSA #14496

merged 2 commits into from
Apr 8, 2023

Commits on Apr 4, 2023

  1. [TIR][Utils] Implemented ConvertSSA as IRModule transform 

    When passes create new PrimFuncs, such as when `tir.SplitHostDevice`
separates out a `tir::Stmt` into an independent function, the
parameters of these new function may alias existing variable
definitions.  While this is well-defined, because variable definitions
are not shared across function boundaries, it can give false
discrepancies from `tvm.ir.assert_structural_equal`.

This commit implements `tvm::tir::transform::ConvertSSA`, which
ensures unique variable declaration locations across an entire module.
    @Lunderberg
    Lunderberg committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c2c4572 View commit details
    Browse the repository at this point in the history

  2. [TIR] Update SplitHostDevice to post-process with ConvertSSA 

    Avoid duplicate variable defitions between the host and device
PrimFunc.
    @Lunderberg
    Lunderberg committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bb768b0 View commit details
    Browse the repository at this point in the history