Change const to used dtype if it is passed in #7285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookhart
requested changes
Jan 14, 2021
tests/python/relay/test_const.py
Outdated
|
|
||
| def test_const_dtype(): | ||
| strides = (1, 1) | ||
| np_array = np.array(strides) |
There was a problem hiding this comment.
Maybe explicitly cast this to int32 before making the const to ensure we'd hit the error in linux with the old behavior?
There was a problem hiding this comment.
I was just hoping that windows would make int32 but your suggestion is much better.
mbrookhart
approved these changes
Jan 14, 2021
zhiics
approved these changes
Jan 15, 2021
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
* Add fix and unit test for const autoconvert dtype. * formatting * Address review comment, casting input value to int32 * Fix failing test * Augment unit test
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* Add fix and unit test for const autoconvert dtype. * formatting * Address review comment, casting input value to int32 * Fix failing test * Augment unit test
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* Add fix and unit test for const autoconvert dtype. * formatting * Address review comment, casting input value to int32 * Fix failing test * Augment unit test
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* Add fix and unit test for const autoconvert dtype. * formatting * Address review comment, casting input value to int32 * Fix failing test * Augment unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dtype is passed then the value is autoconverted to dtype. Windows defaults python integers to int32 while linux defaults to int64. This causes issues in the onnx frontend where constants are created with dtype=int64 but on Windows they would result in int32 constants and break the importer.
https://discuss.tvm.apache.org/t/onnx-frontend-giving-an-error-when-working-a-simple-model-with-tvm/8742