[BYOC][bugfix] Handle empty tuples in annotation pass #7288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyubomirsky
commented
Jan 15, 2021
comaniac
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
LGTM.
Also cc @codeislife99 @anijain2305 who recently worked on this pass as well.
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a small issue when constructing a test case involving the
AnnotateTargetpass and a function returning an empty tuple -- it was inserting acompiler_endannotation without a correspondingcompiler_beginannotation. It turns out there was a check missing fromInsertCompilerEndAndPropogateTarget(it checks for calls without args but not for empty tuples). This PR inserts a check and adds a test case.Please review @zhiics @comaniac