From eebe5bf85892c956a9ede1188df7e780bd88aada Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Tue, 31 Aug 2021 14:52:15 +0000 Subject: [PATCH 1/7] Move to new style issue template system This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update. --- .github/ISSUE_TEMPLATE/bug-report.md | 26 +++++++++++++++++ .github/ISSUE_TEMPLATE/ci-update.md | 29 +++++++++++++++++++ .../feature-tracking.md} | 15 +++++++--- 3 files changed, 66 insertions(+), 4 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/ci-update.md rename .github/{ISSUE_TEMPLATE.md => ISSUE_TEMPLATE/feature-tracking.md} (61%) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md new file mode 100644 index 000000000000..2325ef15a0b9 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -0,0 +1,26 @@ +--- +name: "\U0001F41B Bug report" +about: To help the developer act on the issues, please include a description of your environment, preferably a minimum script to reproduce the problem. +title: "[Bug] " + +--- + +Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :smile_cat: + +Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. + +### Expected behavior + +What you were expecting + +### Actual behavior + +What actually happened + +### Environment + +Any environment details, such as: Operating System, TVM version, etc + +### Steps to reproduce + +Preferably a minimal script to cause the issue to occur. diff --git a/.github/ISSUE_TEMPLATE/ci-update.md b/.github/ISSUE_TEMPLATE/ci-update.md new file mode 100644 index 000000000000..9e20810fea99 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/ci-update.md @@ -0,0 +1,29 @@ +--- +name: "\U0001F40B Update CI Docker Image" +about: Provide information on CI Docker Images requiring updates +title: "[CI] " + +--- + +Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :smile_cat: + +Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. + +[] S0. Reason: For example, a blocked PR or a feature issue + +[] S1. Tag of nightly build: TAG. Docker hub: https://hub.docker.com/layers/tlcpackstaging/ci_cpu/... + +[] S2. The nightly is built on TVM commit: TVM_COMMIT. Detailed info can be found here: https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdaily-docker-image-rebuild/detail/daily-docker-image-rebuild/.... + +[] S3. Testing the nightly image on ci-docker-staging: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/... + +[] S4. Retag TAG to VERSION: +``` +docker pull tlcpackstaging/IMAGE_NAME:TAG +docker tag tlcpackstaging/IMAGE_NAME:TAG tlcpack/IMAGE_NAME:VERSION +docker push tlcpack/IMAGE_NAME:VERSION +``` + +[] S5. Check if the new tag is really there: https://hub.docker.com/u/tlcpack + +[] S6. Submit a PR updating the IMAGE_NAME version on Jenkins diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE/feature-tracking.md similarity index 61% rename from .github/ISSUE_TEMPLATE.md rename to .github/ISSUE_TEMPLATE/feature-tracking.md index 0e2a130d489e..03212c6a902a 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE/feature-tracking.md @@ -1,7 +1,14 @@ -Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :) +--- +name: "\U0001F527 Feature Tracking" +about: List clear, small actionable items so we can track the progress of the change. +labels: type:rfc-tracking +title: "[Tracking Issue] " -Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. +--- + +Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :smile_cat: -For bug reports, to help the developer act on the issues, please include a description of your environment, preferably a minimum script to reproduce the problem. +Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. -For feature proposals, list clear, small actionable items so we can track the progress of the change. +### This issue to track progress for FEATURE NAME +[] P1. Title of this piece of the feature (PR link if available) From e6833ee3bc19f0dda1b770a18c195c1d215e1cf6 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 14:48:12 +0100 Subject: [PATCH 2/7] Fix checkboxes --- .github/ISSUE_TEMPLATE/ci-update.md | 14 +++++++------- .github/ISSUE_TEMPLATE/feature-tracking.md | 2 +- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/ci-update.md b/.github/ISSUE_TEMPLATE/ci-update.md index 9e20810fea99..3e67ac54d520 100644 --- a/.github/ISSUE_TEMPLATE/ci-update.md +++ b/.github/ISSUE_TEMPLATE/ci-update.md @@ -9,21 +9,21 @@ Thanks for participating in the TVM community! We use https://discuss.tvm.ai for Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. -[] S0. Reason: For example, a blocked PR or a feature issue +- [ ] S0. Reason: For example, a blocked PR or a feature issue -[] S1. Tag of nightly build: TAG. Docker hub: https://hub.docker.com/layers/tlcpackstaging/ci_cpu/... +- [ ] S1. Tag of nightly build: TAG. Docker hub: https://hub.docker.com/layers/tlcpackstaging/ci_cpu/... -[] S2. The nightly is built on TVM commit: TVM_COMMIT. Detailed info can be found here: https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdaily-docker-image-rebuild/detail/daily-docker-image-rebuild/.... +- [ ] S2. The nightly is built on TVM commit: TVM_COMMIT. Detailed info can be found here: https://ci.tlcpack.ai/blue/organizations/jenkins/docker-images-ci%2Fdaily-docker-image-rebuild/detail/daily-docker-image-rebuild/.... -[] S3. Testing the nightly image on ci-docker-staging: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/... +- [ ] S3. Testing the nightly image on ci-docker-staging: https://ci.tlcpack.ai/blue/organizations/jenkins/tvm/detail/ci-docker-staging/... -[] S4. Retag TAG to VERSION: +- [ ] S4. Retag TAG to VERSION: ``` docker pull tlcpackstaging/IMAGE_NAME:TAG docker tag tlcpackstaging/IMAGE_NAME:TAG tlcpack/IMAGE_NAME:VERSION docker push tlcpack/IMAGE_NAME:VERSION ``` -[] S5. Check if the new tag is really there: https://hub.docker.com/u/tlcpack +- [ ] S5. Check if the new tag is really there: https://hub.docker.com/u/tlcpack -[] S6. Submit a PR updating the IMAGE_NAME version on Jenkins +- [ ] S6. Submit a PR updating the IMAGE_NAME version on Jenkins diff --git a/.github/ISSUE_TEMPLATE/feature-tracking.md b/.github/ISSUE_TEMPLATE/feature-tracking.md index 03212c6a902a..8e883c1e1478 100644 --- a/.github/ISSUE_TEMPLATE/feature-tracking.md +++ b/.github/ISSUE_TEMPLATE/feature-tracking.md @@ -11,4 +11,4 @@ Thanks for participating in the TVM community! We use https://discuss.tvm.ai for Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. ### This issue to track progress for FEATURE NAME -[] P1. Title of this piece of the feature (PR link if available) +- [ ] P1. Title of this piece of the feature (PR link if available) From 1cd55e24b015c3309b88c49fcfe5cac634c98420 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 14:16:37 +0000 Subject: [PATCH 3/7] Codify the use of Discourse rather than raising issues --- .github/ISSUE_TEMPLATE/config.yml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yml diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml new file mode 100644 index 000000000000..ef55b6355308 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -0,0 +1,5 @@ +blank_issues_enabled: false # default: true +contact_links: +- name: 💬 Discourse + url: https://discuss.tvm.apache.org/ + about: Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first 😺 From 296f9c1557de14a09ddcd6e49ae2f70d80b40722 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 16:51:03 +0000 Subject: [PATCH 4/7] Change CI to CI Image and introduce CI Issue template --- .../{ci-update.md => ci-image.md} | 2 +- .github/ISSUE_TEMPLATE/ci-issue.md | 22 +++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) rename .github/ISSUE_TEMPLATE/{ci-update.md => ci-image.md} (98%) create mode 100644 .github/ISSUE_TEMPLATE/ci-issue.md diff --git a/.github/ISSUE_TEMPLATE/ci-update.md b/.github/ISSUE_TEMPLATE/ci-image.md similarity index 98% rename from .github/ISSUE_TEMPLATE/ci-update.md rename to .github/ISSUE_TEMPLATE/ci-image.md index 3e67ac54d520..d5abd8f20f80 100644 --- a/.github/ISSUE_TEMPLATE/ci-update.md +++ b/.github/ISSUE_TEMPLATE/ci-image.md @@ -1,7 +1,7 @@ --- name: "\U0001F40B Update CI Docker Image" about: Provide information on CI Docker Images requiring updates -title: "[CI] " +title: "[CI Image] " --- diff --git a/.github/ISSUE_TEMPLATE/ci-issue.md b/.github/ISSUE_TEMPLATE/ci-issue.md new file mode 100644 index 000000000000..ac4a7ceee61f --- /dev/null +++ b/.github/ISSUE_TEMPLATE/ci-issue.md @@ -0,0 +1,22 @@ +--- +name: "\U0000274C CI Issue" +about: To help the developers act on these issues, please give us as many details of the CI failure as possible. +title: "[CI Issue] " + +--- + +Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking. You are always welcomed to post on the forum first :smile_cat: + +Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. + +### Branch/PR Failing + +Please provide a link to the PR that has failed to run CI. + +### Jenkins Link + +Provide a link to the specific run that has failed. + +### Flakiness + +Have you seen this multiple times in this branch or in other branches? \ No newline at end of file From f77305f9279c7e0697517ca3f7aa6415e36a75c6 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 16:58:29 +0000 Subject: [PATCH 5/7] Fix poor english --- .github/ISSUE_TEMPLATE/feature-tracking.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/feature-tracking.md b/.github/ISSUE_TEMPLATE/feature-tracking.md index 8e883c1e1478..65fc68937762 100644 --- a/.github/ISSUE_TEMPLATE/feature-tracking.md +++ b/.github/ISSUE_TEMPLATE/feature-tracking.md @@ -10,5 +10,5 @@ Thanks for participating in the TVM community! We use https://discuss.tvm.ai for Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed. -### This issue to track progress for FEATURE NAME +### This issue is to track progress for FEATURE NAME - [ ] P1. Title of this piece of the feature (PR link if available) From 8eec7cf3e5e5868629d18695e958b05aeadb3753 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 19:16:30 +0100 Subject: [PATCH 6/7] Add more tags where we have them --- .github/ISSUE_TEMPLATE/bug-report.md | 1 + .github/ISSUE_TEMPLATE/feature-tracking.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md index 2325ef15a0b9..532f5f408b35 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -2,6 +2,7 @@ name: "\U0001F41B Bug report" about: To help the developer act on the issues, please include a description of your environment, preferably a minimum script to reproduce the problem. title: "[Bug] " +labels: "type: bug" --- diff --git a/.github/ISSUE_TEMPLATE/feature-tracking.md b/.github/ISSUE_TEMPLATE/feature-tracking.md index 65fc68937762..8dd0648f69d4 100644 --- a/.github/ISSUE_TEMPLATE/feature-tracking.md +++ b/.github/ISSUE_TEMPLATE/feature-tracking.md @@ -1,8 +1,8 @@ --- name: "\U0001F527 Feature Tracking" about: List clear, small actionable items so we can track the progress of the change. -labels: type:rfc-tracking title: "[Tracking Issue] " +labels: type:rfc-tracking --- From 7742e67f56b462784a01dee2ed0a883313bf3cd2 Mon Sep 17 00:00:00 2001 From: Chris Sidebottom Date: Wed, 1 Sep 2021 19:17:32 +0100 Subject: [PATCH 7/7] CI Issue -> CI Problem --- .github/ISSUE_TEMPLATE/{ci-issue.md => ci-problem.md} | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) rename .github/ISSUE_TEMPLATE/{ci-issue.md => ci-problem.md} (83%) diff --git a/.github/ISSUE_TEMPLATE/ci-issue.md b/.github/ISSUE_TEMPLATE/ci-problem.md similarity index 83% rename from .github/ISSUE_TEMPLATE/ci-issue.md rename to .github/ISSUE_TEMPLATE/ci-problem.md index ac4a7ceee61f..f46a42f42cf5 100644 --- a/.github/ISSUE_TEMPLATE/ci-issue.md +++ b/.github/ISSUE_TEMPLATE/ci-problem.md @@ -1,7 +1,7 @@ --- -name: "\U0000274C CI Issue" -about: To help the developers act on these issues, please give us as many details of the CI failure as possible. -title: "[CI Issue] " +name: "\U0000274C CI Problem" +about: To help the developers act on these problems, please give us as many details of the CI failure as possible. +title: "[CI Problem] " ---