-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pass to fold type transformations into function signature #9357
Conversation
cc @electriclilies can you review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments -- overall looks like you are on the right track!
(Also I realized after reviewing that this is still marked as draft, oops. let me know when it is ready for another review and I'll take a look again)
After taking another look, I'm a bit confused how you're doing the rewrite of the function parameters, added some questions related to that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, would be great if you could add one comment to the CallNode visitor saying that that logic is only for removing the casts, and also change the opt level
@anwang2009 Please take a look at the CI problem. |
@anwang2009 do you still have interest in merging this PR? |
@AndrewZhaoLuo @anwang2009 are you guys doing this as part of #8296 or is that just related? |
@anwang2009 any plans to continue working on this PR? I think people do request things like this. |
Unrelated to that issue linked. I plan to continue working on this, I just need to find the time 🙃 |
As title.
This transformer gives users more control over where preprocessing steps may be located, and what input types their relay program can accept