[microNPU] Refactor base address determination to codegen #9929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manupak
requested review from
anijain2305,
areusch,
comaniac,
Hzfengsy,
icemelon,
jroesch,
junrushao,
jwfromm,
kparzysz-quic,
MarisaKirisame,
masahi,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu,
zhiics and
ZihengJiang
as code owners
|
cc : @grant-arm @Mousius @ekalda @mbaret |
manupak
force-pushed
the
micronpu_base_address_refactor
branch
from
e36f4bf
to
48a7911
Compare
|
a friendly ping for reviews! TIA. |
mbaret
reviewed
Jan 17, 2022
python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
Outdated
Show resolved
Hide resolved
python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
Outdated
Show resolved
Hide resolved
python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
Outdated
Show resolved
Hide resolved
python/tvm/relay/backend/contrib/ethosu/tir_to_cs_translator.py
Outdated
Show resolved
Hide resolved
|
Thanks @mbaret for the quick review! and I believe I've addressed the comments. |
|
a friendly ping for @grant-arm @Mousius |
Mousius
approved these changes
Jan 18, 2022
There was a problem hiding this comment.
This looks good to me @manupa-arm, I'd be cautious of over-using utils as a general place to put things though as it's unclear where the functional boundary is. I'd suggest renaming it to objects.cc which is one step less vague, or splitting it further in future.
|
Thanks for this @manupa-arm , it looks good to me. |
manupak
force-pushed
the
micronpu_base_address_refactor
branch
3 times, most recently
from
8a71a57
to
378cbc1
Compare
manupak
force-pushed
the
micronpu_base_address_refactor
branch
2 times, most recently
from
4e60749
to
bab07be
Compare
This commit introduces BaseAddress ObjectRef to determine base addresses in the codegen for microNPU. This is required when multiple memory pools become available. Thus, base addresses could not be statically determined in the source module. Change-Id: I6cfa578af0318bbe07d3bb9415df7bdd839611d3
* Renaming runtime_allocate to be scratch again. * Docstring adjustments. Change-Id: Ife8baf97f3dc9348718bd03e62549169a466fc34
manupak
force-pushed
the
micronpu_base_address_refactor
branch
from
bab07be
to
01b1307
Compare
|
@Mousius that make sense. lets rename it to be objects in a follow up. This passed CI :) finally. Can we take this in ? |
sunggg
pushed a commit
to sunggg/tvm
that referenced
this pull request
Jan 29, 2022
This commit introduces BaseAddress ObjectRef to determine base addresses in the codegen for microNPU. This is required when multiple memory pools become available. Thus, base addresses could not be statically determined in the source module.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This commit introduces BaseAddress ObjectRef to determine base addresses in the codegen for microNPU. This is required when multiple memory pools become available. Thus, base addresses could not be statically determined in the source module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces BaseAddress ObjectRef to determine
base addresses in the codegen for microNPU. This is
required when multiple memory pools become available. Thus,
base addresses could not be statically determined in the
source module.