Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate compiler to use Dart Sass #32

Closed
4 tasks done
apalfrey opened this issue May 25, 2021 · 0 comments · Fixed by #40
Closed
4 tasks done

Migrate compiler to use Dart Sass #32

apalfrey opened this issue May 25, 2021 · 0 comments · Fixed by #40
Labels
dependencies Issues or pull requests that update a dependency file pending release Enhancement/bug has been finished, awaiting next release

Comments

@apalfrey
Copy link
Owner

apalfrey commented May 25, 2021

Since 2020-10-26, node-sass has been deprecated: https://sass-lang.com/blog/libsass-is-deprecated

Currently this project is using gulp-sass for it's compiling which uses node-sass. While gulp-sass DOES allow you to pick a compiler to use, it still includes node-sass as a dependency which is unnecessary.

gulp-dart-sass is a fork of gulp-sass which already uses Dart Sass (as it's name suggests). However, due to the way Yarn works, we can only work with the version of Dart Sass it supplies. While this is currently the latest version, including any the Bootstrap variables file (required for our variables) results in deprecation warnings for division operators: twbs/bootstrap#34051

So, this will have to be done in steps in order to ensure compatibility remains without warning messages;

  • Replace Yarn with vanilla npm
  • Replace gulp-sass with gulp-dart-sass
  • Add sass@1.32.13 to prevent deprecation messages
  • Update sass to latest once Bootstrap updates with deprecation fixes

The first 3 parts should be fine to do straight away, however the final part will require waiting until the fixes are in place on Bootstraps end. Once they are, if any issues crop up from this project, we can take care of them as necessary

@apalfrey apalfrey added the dependencies Issues or pull requests that update a dependency file label May 25, 2021
@apalfrey apalfrey added the on hold This issue/pull request is currently on hold label May 25, 2021
@apalfrey apalfrey linked a pull request Jul 27, 2021 that will close this issue
@apalfrey apalfrey added pending release Enhancement/bug has been finished, awaiting next release and removed on hold This issue/pull request is currently on hold labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or pull requests that update a dependency file pending release Enhancement/bug has been finished, awaiting next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant