-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section type that doesn't minimise #96
Comments
or it could union with some other section after that section has been minimized to avoid having to create a new section in the binary. |
@mr-martian that sounds a bit more complicated. Also, it would be cool to be able to give weights to sections, but I'll open another issue for that. |
Upon poking around a bit, I've determined that this would not break the binary format, since section types are just encoded as strings and Either way, this should probably be accompanied by a way to mark |
This should be optional. For development it should be fast to compile and test, but for distribution it should heavily optimize to the smallest/fastest output binary. |
Also, it occurs to me that this is tricky because |
But this is about speed – is minimising each pardef on its own slow? (Last time I checked, the section minimisation at the end was the slow step.) |
Another alternative is that 0493630 added the ability to compile dictionaries in several pieces, which should alleviate the burden of frequently recompiling the regex sections. |
In fact, we could have globally shared regex sections, as proposed in apertium/apertium#161 |
minimisation has gotten quite a bit faster lately. but there's a related pr at #165 |
At the moment we add regexes in sections. Minimising regexes takes a long time. So perhaps we could have a special
type="regex"
section that does not minimise, it would speed up compilation of regex-heavy dictionaries.This will likely break binary compatibility.
The text was updated successfully, but these errors were encountered: