Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide completions for global modifier #280

Open
pwrightcertinia opened this issue Aug 12, 2024 · 0 comments · May be fixed by #313
Open

Provide completions for global modifier #280

pwrightcertinia opened this issue Aug 12, 2024 · 0 comments · May be fixed by #313
Assignees
Labels
bug Something isn't working

Comments

@pwrightcertinia
Copy link
Contributor

pwrightcertinia commented Aug 12, 2024

The completion provider currently filters items to public only, where it should consider visibility field on type declaration.

Following standard rules would be global/public allow any completion, protected only works if the type extends. private access is already implemented so perhaps a general review is required.

See this area of code

@pwrightcertinia pwrightcertinia added the bug Something isn't working label Aug 12, 2024
@nawforce nawforce self-assigned this Dec 15, 2024
@nawforce nawforce linked a pull request Dec 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants