Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to configure initialAngle #11

Merged
merged 2 commits into from
Jul 22, 2019
Merged

allow to configure initialAngle #11

merged 2 commits into from
Jul 22, 2019

Conversation

mschneider
Copy link
Contributor

  • allow to configure initialAngle
  • set initialAngle to always start at 12 o'clock

@mschneider
Mschneider/config initial angle (#1)
04f3d4e 
* Allow to customize initialAngle
* set initialAngle to always start at 12 o'clock
@apgapg
Copy link
Owner

apgapg commented Jul 12, 2019

Hi thanks for this cool parameter. This is something useful.
The only thing that's just breaking is the default value of this param. I guess you should set it to 0 by default so as the current widget doesn't get any UI changes.

Rest is all good. Looking forward to your response. Thanks for the contribution

@mschneider
Copy link
Contributor Author

mschneider commented Jul 12, 2019 •
edited
Loading

Updated it, for me it was more logical to start at 0 but I don't mind to revert that change. Merge as you wish :)

@mschneider
Copy link
Contributor Author

ping

@apgapg apgapg merged commit 0af195a into apgapg:master Jul 22, 2019
@wajahat414 wajahat414 mentioned this pull request May 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mschneider @apgapg