chore: support symfony 7 #6009
Merged
chore: support symfony 7 #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks. This is a bit out of my league, so I'll continue to test and cheer from the sidelines. API Platform is amazing. Thanks for releasing and supporting it! |
|
@tacman I think that upgrading the minor version of symfony would require us to bump a minor version as well. API Platform 3.4 will be out in February we will think about upgrading symfony to 6.4 as a minimal requirement at this moment! |
Symfony 7 adds a new parameter `$buildDir` to `WarmableInterface::warmUp()`, so that the method signature of `CachePoolClearerCacheWarmer::warmUp()` needs to be updated.
dunglas
approved these changes
Nov 30, 2023
|
Sorry for the dumb question, but how can I test this? Isn't right, nor dev-main. |
|
@tacman: It's moot now, since it's released in 3.1.27, but I think you wanted:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6007 #6004
Needed:
$buildDirtoCachePoolClearerCacheWarmer::warmUp()#6008