-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make zod peer dependency #109
Comments
But wouldn't this result in the potential for two versions of zod being present? |
Mhh, how? |
If versions diverged and the peer dependency had say |
It doesn't matter even if they diverge. The peer dependencies are not installed automatically (users need to install them manually) so you won't end up with two version used at the same time. When publishing the package, all dev dependencies are ignored so what we effectively end up with is package without |
I'm saying that zod version that this package gets tested against becomes uncoupled from the one installed and used, which would be bad. |
For reference, we are bundling zod (same way as in OIS currently) in all other repos and it works without issues. |
It should resolve https://github.com/api3dao/ois#make-sure-only-one-zod-version-is-installed
Btw. (if this is not clear),
zod
can (and should) still be installed as a dev dependency in order for tests to run. But it will not end up in a prod bundle.The text was updated successfully, but these errors were encountered: