Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support imports property in swagger export #3

Open
rlmartin opened this issue May 4, 2017 · 1 comment
Open

Support imports property in swagger export #3

rlmartin opened this issue May 4, 2017 · 1 comment

Comments

@rlmartin
Copy link
Collaborator

rlmartin commented May 4, 2017

If service.imports is non-empty, we should recursively pull down the referenced service.json and add it to the swagger.json. We'll need to figure out the logic around how to choose which definition should take precedence when there are collisions. For example: what if the imported definition has the same model but a different definition of the model? Should the models be combined (like a union)? Should the imported one replace the original one? Should the original one remain unaltered? Same thing goes for all levels of the definition, i.e. collisions on resources, parameters, operations, etc.

@rlmartin
Copy link
Collaborator Author

rlmartin commented May 5, 2017

The hbcmobile-wishlist-api.json test resource uses imports, and the invalid swagger spec that is produced should become valid once this issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant