Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: concurrency option override order #1649

Merged
merged 3 commits into from
Nov 2, 2022
Merged

fix: concurrency option override order #1649

merged 3 commits into from
Nov 2, 2022

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Nov 2, 2022

closes #1646

B4nan
B4nan approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some test would be nice

@B4nan B4nan merged commit 7bbad03 into master Nov 2, 2022
@B4nan B4nan deleted the fix/autoscaledPoolvsCrawler branch November 2, 2022 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4nan B4nan B4nan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoscaledPoolOptions and CrawlerOptions don't mix well
2 participants
@barjin @B4nan