fix(MemoryStorage): handling of readable streams for key-value stores when setting records #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll PR an anyObject validator to shapeshift
B4nan
approved these changes
Mar 29, 2023
vladfrangu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an internally reported bug that caused streams provided to never be read and drained
This also corrects the validator for the value, and removes the other redundant checks that happen when validating an object (called constraints, which are extra validators on top of simple typeof checks) (this is also a feature request for shapeshift!). This might actually (finally) solve #1843 but testing needs to be done