Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass on an invisible CF turnstile #2277

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

barjin
Copy link
Contributor

@barjin barjin commented Jan 9, 2024

We only want the CLOUDFLARE_RETRY_CSS_SELECTORS to target the Cloudflare "challenge page", not the invisible Turnstile element (the Cloudflare alternative to Captcha - also included in the challenge page) as the Turnstile widget can be just rendered into the page (along with all the other content).

Closes #2256

@barjin barjin added the t-tooling Issues with this label are in the ownership of the tooling team. label Jan 9, 2024
@barjin barjin self-assigned this Jan 9, 2024
@barjin barjin marked this pull request as ready for review January 9, 2024 13:47
@github-actions github-actions bot added this to the 80th sprint - Tooling team milestone Jan 9, 2024
@barjin barjin merged commit d8734e7 into master Jan 11, 2024
8 checks passed
@barjin barjin deleted the fix/invisible-cf-turnstile branch January 11, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cloudflare retry selector is incorrectly targeted on a specific website
1 participant