Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve FACEBOOK_REGEX to match older style page URLs #2650

Merged

Conversation

gijoehosaphat
Copy link
Contributor

@gijoehosaphat gijoehosaphat commented Aug 30, 2024

Older Facebook URLs could be formatted like this:
https://www.facebook.com/some-profile-1234

This package currently incorrectly parses the URL as:
https://www.facebook.com/some

The REGEX for this package does not match the - character. These URLs have been deprecated, and Facebook will redirect these older style URLs to their newer style. We should still match these older style URLs as they are indeed valid, albeit old.

I've added 2 tests to cover these URL patterns, happy to adjust to any feedback.

Closes #2216

@B4nan B4nan changed the title fix: 2216 FACEBOOK_REGEX not matching older style page URLs fix: improve FACEBOOK_REGEX to match older style page URLs Aug 30, 2024
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@B4nan B4nan merged commit a005e69 into apify:master Aug 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FACEBOOK_REGEX incorrectly matches older style valid Facebook URLs
2 participants