fix: improve FACEBOOK_REGEX
to match older style page URLs
#2650
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older Facebook URLs could be formatted like this:
https://www.facebook.com/some-profile-1234
This package currently incorrectly parses the URL as:
https://www.facebook.com/some
The REGEX for this package does not match the
-
character. These URLs have been deprecated, and Facebook will redirect these older style URLs to their newer style. We should still match these older style URLs as they are indeed valid, albeit old.I've added 2 tests to cover these URL patterns, happy to adjust to any feedback.
Closes #2216