fix: forefront request fetching in RQv2
#2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
vladfrangu
reviewed
Oct 1, 2024
barjin
force-pushed
the
fix/rq-forefront-batching
branch
from
81b4ec4 to
259d529
Compare
barjin
added a commit
that referenced
this pull request
Oct 2, 2024
barjin
force-pushed
the
fix/rq-forefront-batching
branch
from
259d529 to
0546643
Compare
vladfrangu
approved these changes
Oct 2, 2024
| this._cacheRequest(getRequestId(uniqueKey), { | ||
| requestId: id, | ||
| uniqueKey, | ||
| wasAlreadyPresent: true, | ||
| wasAlreadyHandled: false, | ||
| }); | ||
| } | ||
|
|
||
| for (const id of forefront ? headIdBuffer.reverse() : headIdBuffer) { |
There was a problem hiding this comment.
Does this reverse matters at all? They're all still gonna be added with forefront so it feels redundant
There was a problem hiding this comment.
Unfortunately it does, as we want to prepend headIdBuffer (as it is) to queueHeadIds - if we push the requests one by one in to the head of queueHeadIds, it would end up reversed:
buffer: 12345
queue: 67890
buffer: 2345
queue: 167890
buffer: 345
queue: 2167890
etc.
I'm not a huge fan of this ternary mumbo-jumbo either, but headIdBuffer is at most 25 items long, so at least this should cause no noticeable perf problem. Readability... that's a different story 🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeps count of the (locally)
forefrontenqueued requests in the RQv2 instance. Uses this counter to signal the need for new remote RQ reads.Note that with the current API, we cannot solve this for request queues with multiple clients. The original behavior is retained in such a scenario.
Closes #2669