fix: prolong- and deleteRequestLock forefront option
#2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request is neither linked to an issue or epic nor labeled as adhoc!
barjin
commented
Oct 2, 2024
| @@ -329,6 +329,7 @@ export class RequestQueueClient extends BaseClient implements storage.RequestQue | |||
| internalRequest.orderNo = forefront ? -unlockTimestamp : unlockTimestamp; | |||
|
|
|||
| await request?.update(internalRequest); | |||
| if (forefront) this.forefrontRequestIds.push(id); | |||
There was a problem hiding this comment.
This is just an approximation - on Platform, the prolongRequestLock forefront order is based on the lock expiration order, not the prolong call order. This means that:
prolong lock on A, 10 seconds, forefront
prolong lock on B, 5 seconds, forefront
...will result in B | A | ...tail in our implementation but A | B | ...tail on Platform.
This feature didn't work at all before this PR - this tells me that we don't need to get this detail completely right. Especially since supporting this would require storing the unlock times in the forefront list and would be a proper mess maintaining with more prolong and delete calls.
barjin
assigned janbuchar, vladfrangu and barjin and unassigned janbuchar, vladfrangu and barjin
janbuchar
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we neglected the
prolonganddeleteRequestLockmethods with #2681 , so these do not respect theforefront-enforced request ordering. This PR fixes this omission.Prerequisite for #2689
Related to #2669