Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crawlee fingerprintOptions do not completely reflect fingerprint-suite's options #2703

Closed
galaczi opened this issue Oct 10, 2024 · 0 comments · Fixed by #2705
Closed

Crawlee fingerprintOptions do not completely reflect fingerprint-suite's options #2703

galaczi opened this issue Oct 10, 2024 · 0 comments · Fixed by #2705
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@galaczi
Copy link

galaczi commented Oct 10, 2024

Which package is this bug report for? If unsure which one to select, leave blank

@crawlee/browser-pool

Issue description

As discussed in #2701 Crawlee doesn't recognize some of the fingerprint-suite's options. Setting mockWebRTC to true works, but Typescript complains.

Code sample

browserPoolOptions: {
      fingerprintOptions: {
        fingerprintGeneratorOptions: {
          mockWebRTC: true
        }
      }
    },


### Package version

3.11.5

### Node.js version

v20.13.1

### Operating system

Ubuntu

### Apify platform

- [ ] Tick me if you encountered this issue on the Apify platform

### I have tested this on the `next` release

_No response_

### Other context

_No response_
@galaczi galaczi added the bug Something isn't working. label Oct 10, 2024
@github-actions github-actions bot added the t-tooling Issues with this label are in the ownership of the tooling team. label Oct 10, 2024
@barjin barjin closed this as completed in fcb098d Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant