Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve errorHandler #947

Closed
mnmkng opened this issue Feb 25, 2021 · 1 comment
Closed

Improve errorHandler #947

mnmkng opened this issue Feb 25, 2021 · 1 comment
Assignees
@szmarczak
Labels
feature Issues that represent new features or improvements to existing features.

Comments

@mnmkng
Copy link
Member

mnmkng commented Feb 25, 2021 •
edited by B4nan
Loading

Describe the feature
Allow errorHandler to work with the full crawling context. For example, make sure that the page is not closed before errorHandler finishes. We should also prevent errors thrown from the function from crashing the crawler and just log them.

Motivation
It is useful to save debugging data or do some final processing in the errorHandler. Now that we created CrawlingContext, page is available in errorHandler, but most of the time, it would be already closing/closed and any page operations will fail. This will most likely crash the crawler.

Constraints
If we catch the errors coming from the function, there should not be any. But let's double check whether there aren't any other issues.
@mnmkng mnmkng added the feature Issues that represent new features or improvements to existing features. label Feb 25, 2021
@B4nan B4nan changed the title Improve handleFailedRequestFunction Improve errorHandler Jul 20, 2022
@szmarczak szmarczak self-assigned this Sep 12, 2022
@B4nan B4nan mentioned this issue Sep 19, 2022
Merged
@szmarczak
Copy link
Contributor

Fixed in #1548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szmarczak szmarczak

Labels
feature Issues that represent new features or improvements to existing features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnmkng @szmarczak