-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #165 - npm run remotetest completes cleanly #166
Conversation
The gist of these fixes are:
|
Test for Issue #159 |
Test for Issue #162 |
Test for Issue #167 |
All done!
$ npm run remotetest (NOTE: hosted target fails due to current omg/16078)
Remote Tests Node.js Apps Hosted Target Caches Target Servers KVM SharedFlows and FlowHooks User Roles and Permissions 70 passing (8m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question about removing the --json
flag.
README.md
Outdated
@@ -76,9 +82,6 @@ trusted TLS certificate. | |||
(optional) Limit for the maximum number of operations performed concurrently. | |||
Currently this only affects file uploads in the `deploynodeapp` command. Defaults to 4. | |||
|
|||
`--json -j` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not, my bad, I wasn't sure what it was for, but now I do.
I'll add it back.
While fixing remotetest.js, identified and fixed additional issues #158 #160 #161 and #163
Unfortunately, there are a lot of formatting changes to remotetest.js