-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial working multigraph edge validator plus tests #107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 88.03% 88.44% +0.41%
==========================================
Files 24 25 +1
Lines 1763 1843 +80
==========================================
+ Hits 1552 1630 +78
- Misses 211 213 +2
Continue to review full report at Codecov.
|
@hpawa and @celiibrendan — I am finding (not unexpectedly) that proper multigraph support is going to take a little more engineering here. For now, I think it's reasonable to use the Here's one such case, to illustrate what I mean: A -> B [size > 10, size < 10] Imagine there are two edges between host nodes I'm going to work on building a better system when my brain isn't fried, but I think this is doable. Just... perhaps not tonight :) |
Based upon the work in #106 (thanks @celiibrendan!) and fixes #101.